search

billdeitrick / pypco

A Python client for the Planning Center Online API.
MIT License
39 stars 13 forks source link

Added typing to whole project and test it with mypy #54

Closed 07pepa closed 2 years ago

07pepa commented 2 years ago

fixing issue https://github.com/billdeitrick/pypco/issues/48

added testing of types via mypy

codecov[bot] commented 2 years ago

Codecov Report

Merging #54 (f1318c8) into master (2873685) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          173       175    +2     
=========================================
+ Hits           173       175    +2
Impacted Files Coverage Δ
pypco/auth_config.py 100.00% <100.00%> (ø)
pypco/pco.py 100.00% <100.00%> (ø)
pypco/user_auth_helpers.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

billdeitrick commented 2 years ago

@07pepa This is great--thanks for doing this. Read through your changes and ran it through the new CI pipeline @pastorhudson and I have been working on and everything looks great.

The only thing I would like to do as mentioned above is get a unit test on that code where you fixed the typo. Should just be a matter of adding an assert to in this test case. If you have a chance to add this that's fine, otherwise I should be able to do so tomorrow or Wednesday.

07pepa commented 2 years ago

i have some tooth pain so i will relive mylef till monday

and maybe we found a bug in python interpreter

pastorhudson commented 2 years ago

I'm praying you feel better! Thank you for this PR. Very cool!

07pepa commented 2 years ago

i added test and did some housecleaning on that file but there is is some stuff i did not like and se as potential problems with some improvements... i will create an issue to summ my ideas up

07pepa commented 2 years ago

@billdeitrick if you are bussy just tell me but just i am reminding this is now tested and ready to merge

billdeitrick commented 2 years ago

@07pepa Thanks for your patience, and for your work on this. I'm just about done reviewing your changes and should have time to get this merged tonight. Great work!

07pepa commented 2 years ago

btw i want to use this on one of my project to just want to get the library into more fit shape 1st and then use it