search

billdeitrick / pypco

A Python client for the Planning Center Online API.
MIT License
39 stars 13 forks source link

Update pylint #55

Open billdeitrick opened 2 years ago

billdeitrick commented 2 years ago

We had to pin pylint with the new CI pipeline because the newer version was throwing various linting errors. Need unpin pylint and resolve these errors.

pastorhudson commented 1 year ago

This is related to issue #57

07pepa commented 1 year ago

i may help

pastorhudson commented 1 year ago

I have pycharm pro I can just tell it to fix all the code formatting and see if it works with the new pylint. Or we could try something like black as a pre-commit, but that will add some complexity.

pastorhudson commented 1 year ago

I read that as "I may need help" 😅 @07pepa id you want to tackle this that would be great!

07pepa commented 1 year ago

Hehe yea this is "hell" of being non native english speaker.... In 🇨🇿 (czech} language I could even drop "I" and from form of verb of "may" you could backtrack that i ment myself

well i am just rolling Comunity edition (and i may suggest others like flake8 as well} but worth checking other big project like pydantic or fastapi

and i am not againts precomit if there is explanation with simple fix (like just run this and that) and you will be able to comit i thing it will not be a problem for other commiters

but what i would like that code will not shine like christmass tree in pycharm (so a format as close as it can be)