search

billdenney / pknca

An R package is designed to perform all noncompartmental analysis (NCA) calculations for pharmacokinetic (PK) data.
http://billdenney.github.io/pknca/
GNU Affero General Public License v3.0
68 stars 23 forks source link

Fix for dev testthat #213

Closed hadley closed 1 year ago

hadley commented 1 year ago

Not sure why this worked before.

billdenney commented 1 year ago

Thanks for this. I'm also confused about why it would have worked before.

I understand the switch to expect_message, but why did you also remove the class specification that ensures the correct message is being captured?

hadley commented 1 year ago

I don't know; probably because it failed when it left it in.

billdenney commented 1 year ago

I checked, and leaving the class check in worked, so I restored it.

hadley commented 1 year ago

Just a note that dev testthat will be going to CRAN on May 1 or 2.

billdenney commented 1 year ago

The updated version of PKNCA was just accepted on CRAN.