search

billdenney / pknca

An R package is designed to perform all noncompartmental analysis (NCA) calculations for pharmacokinetic (PK) data.
http://billdenney.github.io/pknca/
GNU Affero General Public License v3.0
67 stars 24 forks source link

option for improving performance by reducing bookkeeping #226

Closed certara-msale closed 1 year ago

certara-msale commented 1 year ago

Would like to add an option to remove any unnecessary "bookkeeping" to improve performance, thanks Mark Sale mark.sale@certara.com

billdenney commented 1 year ago

@certara-msale, I did some profiling of the code, and I think that for large numbers of subjects (I was testing with 1000) there may be a ~50% improvement in speed with the PR that I just merged. Can you please give it a shot and let me know if it helps?

certara-msale commented 1 year ago

Thanks Bill, will be next week I think, report due Monday

Mark Sale M.D. Vice President Integrated Drug Development @.*** Remote-Forestville CA Office Hours 9 AM - 5 PM Eastern Time +1 302-516-1684 www.certara.com [Certara Logo]

From: Bill Denney @.> Sent: Friday, August 4, 2023 8:52 PM To: billdenney/pknca @.> Cc: Mark Sale @.>; Mention @.> Subject: Re: [billdenney/pknca] option for improving performance by reducing bookkeeping (Issue #226)

CAUTION: This email originated from outside of Certara. Do not click links or open attachments unless you recognize the sender and know the content is safe.

@certara-msalehttps://github.com/certara-msale, I did some profiling of the code, and I think that for large numbers of subjects (I was testing with 1000) there may be a ~50% improvement in speed with the PR that I just merged. Can you please give it a shot and let me know if it helps?

- Reply to this email directly, view it on GitHubhttps://github.com/billdenney/pknca/issues/226#issuecomment-1666376784, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYP44EDDDXQDHCYVG4WMWL3XTW7OFANCNFSM6AAAAAA25Q3L2A. You are receiving this because you were mentioned.Message ID: @.**@.>>

This message (including any attachments) may contain confidential, proprietary, privileged and/or private information. The information is intended to be for the use of the individual or entity designated above. If you are not the intended recipient of this message, please notify the sender immediately, and delete the message and any attachments. Any disclosure, reproduction, distribution or other use of this message or any attachments by an individual or entity other than the intended recipient is prohibited.

billdenney commented 1 year ago

Based on offline emails, we were able to speed it up about 30% with the improvements in the recent PR.