search

billerickson / BE-RSS-Builder

Allows you to build custom RSS feeds for email marketing
14 stars 2 forks source link

Media type is missing from images #2

Open jpmorandesign opened 4 years ago

jpmorandesign commented 4 years ago

Trying to use feeds in MailChimp, but the images are not showing up. I think it is because the Image media type is not populated in the feed. I discovered this when comparing the feed to one that was working. see attached

Any thoughts on how to include it in the feed? feed_screen1

billerickson commented 4 years ago

I didn't run into that issue when I first built this for a client, but it's been a while and I don't have access to a MailChimp account that actively uses this plugin anymore.

Try adding the type="image/jpeg" bit here: https://github.com/billerickson/BE-RSS-Builder/blob/master/be-rss-builder.php#L525

If that fixes it, I can patch the plugin.

Thanks

jpmorandesign commented 4 years ago

Thanks for the reply. I don’t think that we need to add the Type to the image entry.

However, is there a way to add a media type to the RSS definitions at the beginning of the feed output.

    xmlns:media="http://search.yahoo.com/mrss/"

This is needed to render images and when missing the feed does not validate.

Oh, one last thing.

I doesn’t appear that the feed generation is honoring the item quantity setting

Patrick

From: Bill Erickson notifications@github.com Reply-To: billerickson/BE-RSS-Builder reply@reply.github.com Date: Monday, December 23, 2019 at 7:11 AM To: billerickson/BE-RSS-Builder BE-RSS-Builder@noreply.github.com Cc: "J. Patrick Moran" patrick@jpmdi.com, Author author@noreply.github.com Subject: Re: [billerickson/BE-RSS-Builder] Media type is missing from images (#2)

I didn't run into that issue when I first built this for a client, but it's been a while and I don't have access to a MailChimp account that actively uses this plugin anymore.

Try adding the type="image/jpeg" bit here: https://github.com/billerickson/BE-RSS-Builder/blob/master/be-rss-builder.php#L525

If that fixes it, I can patch the plugin.

Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/billerickson/BE-RSS-Builder/issues/2?email_source=notifications&email_token=AEJDQ4QLDOMBA4Y4AVYMSLLQ2DBI5A5CNFSM4J6HYX4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHRGONA#issuecomment-568485684, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEJDQ4RTSQZRXJGAYM4H2GTQ2DBI5ANCNFSM4J6HYX4A.

billerickson commented 4 years ago

I actually had that in there originally but removed it for some reason (see here).

I think it was because the namespace was also being added by something else, but don't recall the details now.