search

billforsternz / thc-chess-library

General Purpose Rules of Chess Library for C++
MIT License
38 stars 13 forks source link

Updating a few thinks so it runs on unix #7

Closed manuelliebchen closed 2 years ago

manuelliebchen commented 3 years ago

Adding an include for stdint.h in ChessDefs.h

Replacing strcpy_s with memcpy in src/ChessPosition.h and src/thc.h

billforsternz commented 2 years ago

I am visiting the repo for the first time in a long time. I have some ideas and want to get back into it. I'll start with a little routine maintenance, so looking at issues and PRs. This PR seems reasonable. Replacing strcpy_s with memcpy seems good. But a new #include convention is a serious thing, I'm not sure about it. I suppose changing from to etc. is good, but I don't know about this <__config> thing, I don't necessarily like it. I am going to check with Linux compilers myself using WSL on this new PC of mine. So reserving judgement for now.

billforsternz commented 2 years ago

I think I've addressed the issues in this pull request with my changes today. Thanks for you work, and my apologies for not getting around to doing anything about the issues until now.