billgoo / vscode-tab-group

MIT License
19 stars 4 forks source link

Filetype missing from list #19

Open mlprt opened 1 year ago

mlprt commented 1 year ago

Thanks for writing this extension!

I've noticed that tabs for Jupyter notebooks (*.ipynb) do not appear in the list.

I searched this repo and it doesn't look like Jupyter notebooks are specifically excluded (which is what I'd expect anyway). Maybe the issue is not directly to do with Tab Group, but with how vscode treats .ipynb.

I'm not sure if any other file types would be affected...

macromogic commented 1 year ago

I've noticed the same problem.

Although I have zero experience developing extensions for vscode, I tried to read the source code of this extension and vscode's api definition. It seems like jupyter notebook tabs are recognized as TabInputNotebook, but there is no handler defined for this type of tabs in TabTypeHandler.ts.

I am not sure if my observations are accurate, please correct me if I made mistakes.

Anyway, thanks for writing this amazing extension!

FPMwestjet commented 2 months ago

One year later and i have the same problem. All of my jupyter notebook files (ipynb) dont show up in this extension.