billimarie / prosecutor-database

An open-source, community oversight dataset of all U.S. Prosecutors. Happy Hacktoberfest 🎃

https://billimarie.github.io/prosecutor-database

Other

88 stars 82 forks source link

[CODE] Convert Iron Router to Flow Router #127

Open billimarie opened 3 years ago

billimarie commented 3 years ago

It looks like Iron Router hasn't been updated since 4 years ago. If there is a way to remove it & add Flow Router instead, that would help numerous bugs--including one where we can't click on the attorney card to view the attorney profile.

michaelknowles commented 3 years ago

I can take a look at this one

billimarie commented 3 years ago

Wonderful; I have assigned you this ticket. Feel free to reach out if you come across any issues.

michaelknowles commented 3 years ago

I've implemented Flow Router. Do you have a list of bugs that I can check to ensure they've been fixed by this change?

billimarie commented 3 years ago

Hi @michaelknowles, thank you for taking the lead on this. Unfortunately I did not have a chance to update this issue (which was created before this PR: #129). As of now, there are no bugs which we can discern are caused by Iron Router; in your expertise, which router is working best? I have an inkling Flow Router is the better option due to its more recent updates, but I am curious if there's any reason why we should continue to use Iron Router.

michaelknowles commented 3 years ago

I'm not an expert on Meteor but I don't see a reason to use an abandoned library. Even if we don't have problems now, it's probably good to change before the website gets bigger and more complicated.

michaelknowles commented 3 years ago

158

sumit851 commented 1 year ago

plz assign me to this issue.