search

billimarie / prosecutor-database

An open-source, community oversight dataset of all U.S. Prosecutors. Happy Hacktoberfest 🎃
https://billimarie.github.io/prosecutor-database
Other
88 stars 82 forks source link

add party affiliation filter #157

Closed ghost closed 3 years ago

ghost commented 3 years ago

Fixes #111. I added the party affiliation filter. I thought about following the convention being used for the previous filters, but the if else conditions started getting out of hand pretty fast. So I changed the filter logic to make it a little bit more scalable. Hopefully that will come in use for future filters as well. Let me know if you need me to change anything.

billimarie commented 3 years ago

Beautiful! Thank you for untangling this. Merging. Should be live within the hour; feel free to ping me if anything is amiss.

shariq1989 commented 3 years ago

@rohitkswat Great cleanup job!