search

billimarie / prosecutor-database

An open-source, community oversight dataset of all U.S. Prosecutors. Happy Hacktoberfest 🎃
https://billimarie.github.io/prosecutor-database
Other
87 stars 85 forks source link

[BUG] Mobile: "Vote" Ribbon #65

Closed billimarie closed 4 years ago

billimarie commented 4 years ago

On mobile view of the app, the "vote" ribbon gets in the way of the user experience.

(Additionally: need new link for the ribbon. Suggestions?)

taylor-brudos commented 4 years ago

Hi! Since voting for prosecutors depends on your county/state, I think we should use this link which is an official US government website that instructs how to vote and provides links to do so: https://www.usa.gov/register-to-vote.

taylor-brudos commented 4 years ago

I'm working on updating the link and fixing the mobile view

taylor-brudos commented 4 years ago

Here is the PR for updating the vote link: https://github.com/billimarie/prosecutor-database/pull/69

taylor-brudos commented 4 years ago

Here is the PR for updating the mobile ribbon UX: https://github.com/billimarie/prosecutor-database/pull/70

billimarie commented 4 years ago

Thank you, @taylor-brudos! Closing this issue, as you've solved it in both PRs.