billimek / billimek-charts

DEPRECATED - new home is https://github.com/k8s-at-home/charts
Apache License 2.0
89 stars 52 forks source link

[plex] Add Init script using configMap that will set Plex Preferences using container ENV #211

Closed runecalico closed 4 years ago

runecalico commented 4 years ago

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

runecalico commented 4 years ago

I was expecting it to submit the PR against the current master, but since it had the Chart version as 1.0 in the PR, and it looks like it has all the code that I previously merged in it .. Should I be doing something to have it submit the pr against the current master? Or is it where I need to refork (is that a thing) after my PR's are merged to sync back to master?

billimek commented 4 years ago

It's strange that the github action didn't run on the last two commits.

runecalico commented 4 years ago

Yea, i noticed that .. but it didn't look like I could rerun the linting ... so I hoped that perhaps you would still do it prior to merge.