search

billimek / billimek-charts

DEPRECATED - new home is https://github.com/k8s-at-home/charts
Apache License 2.0
89 stars 52 forks source link

[blocky] Improve values.yaml documentation #220

Closed dewet22 closed 4 years ago

dewet22 commented 4 years ago

Also fix syntax error for declaring extraLists -- it needs to be a map, not an array

Special notes for your reviewer:

No functional changes, only comments reorganisation.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

billimek commented 4 years ago

Thanks @dewet22! Can you please bump the chart version in the Chart.yaml file?

dewet22 commented 4 years ago

Thanks @dewet22! Can you please bump the chart version in the Chart.yaml file?

Of course, wasn't sure whether documentation-only changes merited that.

dewet22 commented 4 years ago

Sorry, actually bumped the wrong chart's version!

billimek commented 4 years ago

Indeed, no worries. Thanks for the pull request @dewet22!