[arr] New Radarr/Sonarr/Lidarr Templated chart

dirtycajunrice commented 4 years ago

As all the charts needs are identical this will do all 3 of them and

allow you to choose between deployment and statefulset via .Values.persistence.type
change only the ports based on the repo name
switch config path to /config if its anything other than itscontained for organization
intentionally fail if it was not given an image, a tag, and/or could not derive a port from either a defined port or the repository

onedr0p commented 4 years ago

I think a readme with some examples might be nice :)

dirtycajunrice commented 4 years ago

Readme needed for sure was just 5 am. will work on it now :)

dirtycajunrice commented 4 years ago

Readme updated. Dont think i can make this pass a chart test with required defaults unless there is a way to specify a ct.yaml inside the chart dir for it specifically.

dirtycajunrice commented 4 years ago

Bit of a pivot... but... tautulli, ombi, and organizr do not allow environmental configuration. this chart would easily be able to encompass all of those as well. This brings up 2 points:

what to name it... media? plex-ecosystem? something else?
Is this the right thing to do?

onedr0p commented 4 years ago

You bring up a good point, all these can be run from one chart. If if there was different ENV configuration this could be solved with extraEnvs in the values.

The pros are maintenance is going to be much easier, the cons are it might be confusing to newcomers (solved by explicit README instructions) and we would need to account for it in the linting workflow (unsure about this one).

If we decide this, we might as well throw bazarr, nzbget, and sabnzbd into the mix too. I throw my coin in the hat for naming it something new like you did with Varken. There's just too much to consider naming it something that related to all of them.

I would like to have @billimek and @carpenike opinion on this too.

bjw-s commented 4 years ago

Readme updated. Dont think i can make this pass a chart test with required defaults unless there is a way to specify a ct.yaml inside the chart dir for it specifically.

You can, see https://github.com/billimek/billimek-charts/tree/master/charts/frigate/ci for an example :)

bjw-s commented 4 years ago

all these can be run from one chart. If if there was different ENV configuration this could be solved with extraEnvs in the values.

Another approach could be to have some sort of "main" chart that has all of the required logic for this, and then have the "child" charts (like all the mentioned arr services) have a chart dependency on it (possibly with an alias to keep the naming in values.yaml recognisable similar to the database dependency that was recently introduced for Home Assistant. That way you would have the benefit of centralising all the logic, and just set the required values in the arr charts. That would also keep the services recognizable for users just looking for a "Sonarr" chart.

Example Sonarr chart.yaml:

apiVersion: v2
appVersion: 2.0.0.5344-ls60
description: Sonarr is a television show downloading client
name: sonarr
version: 4.1.3

dependencies:
- name: <name-of-parent-chart>
  repository: https://billimek.com/billimek-charts
  version: ~1.0.0
  alias: sonarr

Example Sonarr values.yaml:

sonarr:
  image:
    repository: linuxserver/sonarr
    tag: 2.0.0.5344-ls60
    pullPolicy: IfNotPresent

  etc...

billimek commented 4 years ago

Via #317 there is a new home for these charts located https://github.com/k8s-at-home/charts. We cannot transfer PRs so would you kindly re-submit this change as a pull request over in https://github.com/k8s-at-home/charts?

dirtycajunrice commented 4 years ago

New PR https://github.com/k8s-at-home/charts/pull/33

billimek / billimek-charts

[arr] New Radarr/Sonarr/Lidarr Templated chart #329