ChristerNilsson
commented
3 days ago Also misplaced break in line 2145. Has to be deleted.
Open ChristerNilsson opened 3 days ago
ChristerNilsson
commented
3 days ago Also misplaced break in line 2145. Has to be deleted.
ChristerNilsson
commented
3 days ago This seems to be Work In Progress...
billjordanchess
commented
2 days ago Hi Christer,
That's strange, I will have a look.
Bill J
On Sun, Sep 29, 2024 at 5:46 PM Christer Nilsson @.***> wrote:
This seems to be Work In Progress...
— Reply to this email directly, view it on GitHub https://github.com/billjordanchess/JavaScript-Chess/issues/2#issuecomment-2381256578, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMZ45C6SURL7WTUIWNJL5FLZY6ZNHAVCNFSM6AAAAABPBML7TGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGI2TMNJXHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
ChristerNilsson
commented
2 days ago Your claim that white space and long variable names slows the execution down is bogus. The javascript is immediately translated to internal form. Also, this engine’s main purpose is not speed, it is education. So, the code should be as readable as possible. The minification is not meant to be read and should NEVER be published in a book aimed for education.
The indentation is horrible.
I’m using the extinct language Coffeescript. It has a similar mandatory indentation as Python and is transpiled to Javascript. Very readable!
Finally, why bother with web assembly if your main concern is education, not speed? The reader will not be able to debug. The debugger is a wonderful tool to see the internal values, not only finding errors. You took this possibility away.
Please, fix these issues in the next edition, and I will buy the book once more.
/Christer Nilsson 070-749 6800
On Mon, 30 Sep 2024 at 11:26, billjordanchess @.***> wrote:
Hi Christer,
That's strange, I will have a look.
Bill J
On Sun, Sep 29, 2024 at 5:46 PM Christer Nilsson @.***> wrote:
This seems to be Work In Progress...
— Reply to this email directly, view it on GitHub < https://github.com/billjordanchess/JavaScript-Chess/issues/2#issuecomment-2381256578>,
or unsubscribe < https://github.com/notifications/unsubscribe-auth/AMZ45C6SURL7WTUIWNJL5FLZY6ZNHAVCNFSM6AAAAABPBML7TGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGI2TMNJXHA>
. You are receiving this because you are subscribed to this thread.Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/billjordanchess/JavaScript-Chess/issues/2#issuecomment-2382599206, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2HFC32WDKT6VPIDXZRWVLZZEKLRAVCNFSM6AAAAABPBML7TGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBSGU4TSMRQGY . You are receiving this because you authored the thread.Message ID: @.***>
ChristerNilsson
commented
22 hours ago Shift+Alt+F in VS Code made a good format in one second.
The strength of the program is good. I'm investigating simple end games now. KRK seems to need level 10. Amazing, considering two simple piece square tables.
Den tis 1 okt. 2024 kl 03:38 skrev Christer Nilsson < @.***>:
Your claim that white space and long variable names slows the execution down is bogus. The javascript is immediately translated to internal form. Also, this engine’s main purpose is not speed, it is education. So, the code should be as readable as possible. The minification is not meant to be read and should NEVER be published in a book aimed for education.
The indentation is horrible.
I’m using the extinct language Coffeescript. It has a similar mandatory indentation as Python and is transpiled to Javascript. Very readable!
Finally, why bother with web assembly if your main concern is education, not speed? The reader will not be able to debug. The debugger is a wonderful tool to see the internal values, not only finding errors. You took this possibility away.
Please, fix these issues in the next edition, and I will buy the book once more.
/Christer Nilsson 070-749 6800
On Mon, 30 Sep 2024 at 11:26, billjordanchess @.***> wrote:
Hi Christer,
That's strange, I will have a look.
Bill J
On Sun, Sep 29, 2024 at 5:46 PM Christer Nilsson @.***> wrote:
This seems to be Work In Progress...
— Reply to this email directly, view it on GitHub < https://github.com/billjordanchess/JavaScript-Chess/issues/2#issuecomment-2381256578>,
or unsubscribe < https://github.com/notifications/unsubscribe-auth/AMZ45C6SURL7WTUIWNJL5FLZY6ZNHAVCNFSM6AAAAABPBML7TGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRGI2TMNJXHA>
. You are receiving this because you are subscribed to this thread.Message ID: @.***>
— Reply to this email directly, view it on GitHub https://github.com/billjordanchess/JavaScript-Chess/issues/2#issuecomment-2382599206, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2HFC32WDKT6VPIDXZRWVLZZEKLRAVCNFSM6AAAAABPBML7TGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBSGU4TSMRQGY . You are receiving this because you authored the thread.Message ID: @.***>
-- / © +46 70 749 68 00
billjordanchess
commented
2 hours ago I implemented your suggestion of using VS to indent the source code and it worked like magic.
I have uploaded the indented files.
You have inspired me to create a new version which implements some of the changes in JS since I first wrote the engine.
Bill J
On Wed, Oct 2, 2024 at 4:02 PM Christer Nilsson @.***> wrote:
Shift+Alt+F in VS Code made a good format in one second.
The strength of the program is good. I'm investigating simple end games now. KRK seems to need level 10. Amazing, considering two simple piece square tables.
Den tis 1 okt. 2024 kl 03:38 skrev Christer Nilsson < @.***>:
Your claim that white space and long variable names slows the execution down is bogus. The javascript is immediately translated to internal form. Also, this engine’s main purpose is not speed, it is education. So, the code should be as readable as possible. The minification is not meant to be read and should NEVER be published in a book aimed for education.
The indentation is horrible.
I’m using the extinct language Coffeescript. It has a similar mandatory indentation as Python and is transpiled to Javascript. Very readable!
Finally, why bother with web assembly if your main concern is education, not speed? The reader will not be able to debug. The debugger is a wonderful tool to see the internal values, not only finding errors. You took this possibility away.
Please, fix these issues in the next edition, and I will buy the book once more.
/Christer Nilsson 070-749 6800
On Mon, 30 Sep 2024 at 11:26, billjordanchess @.***> wrote:
Hi Christer,
That's strange, I will have a look.
Bill J
On Sun, Sep 29, 2024 at 5:46 PM Christer Nilsson @.***> wrote:
This seems to be Work In Progress...
— Reply to this email directly, view it on GitHub <
https://github.com/billjordanchess/JavaScript-Chess/issues/2#issuecomment-2381256578>,
or unsubscribe <
. You are receiving this because you are subscribed to this thread.Message ID: @.***>
— Reply to this email directly, view it on GitHub < https://github.com/billjordanchess/JavaScript-Chess/issues/2#issuecomment-2382599206>,
or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA2HFC32WDKT6VPIDXZRWVLZZEKLRAVCNFSM6AAAAABPBML7TGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBSGU4TSMRQGY>
. You are receiving this because you authored the thread.Message ID: @.***>
-- / © +46 70 749 68 00
— Reply to this email directly, view it on GitHub https://github.com/billjordanchess/JavaScript-Chess/issues/2#issuecomment-2387722862, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMZ45C3O4MUMB46QLE7U2QDZZOHO7AVCNFSM6AAAAABPBML7TGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBXG4ZDEOBWGI . You are receiving this because you commented.Message ID: @.***>
LoadDiagram sets ts to KQK.