search

billkarsh / SpikeGLX

SpikeGLX recording system GUI [Neuropixels NI]
Other
83 stars 29 forks source link

Crash on SETTRGENAB #1

Closed c-wilson closed 8 years ago

c-wilson commented 8 years ago

Hi Bill,

I've been using SGLX and loving it for the most part. I wanted to bring a bug in the command server to your attention. I can get everything working that I've tried except "SETTRGENAB". This command crashes spikeglx whether I pass a 0 or a 1 if acquisition is running. It does not crash if acquisition is not running, but rather returns "OK" via the socket regardless of whether I pass it a 0 or 1. If I don't pass anything (ie just send "SETTRGENAB") it will report an error in the console and return an error via the socket.

I'm running SpikeGLX v.20151231. I can try to look into the code myself to see what's going on, but I figure you might be able to solve it more efficiently than I.

Cheers

billkarsh commented 8 years ago

Hi Chris,

Bug confirmed…working on fix.

Bill

From: Chris Wilson [mailto:notifications@github.com] Sent: Friday, February 12, 2016 10:57 AM To: billkarsh/SpikeGLX SpikeGLX@noreply.github.com Subject: [SpikeGLX] Crash on SETTRGENAB (#1)

Hi Bill,

I've been using SGLX and loving it for the most part. I wanted to bring a bug in the command server to your attention. I can get everything working that I've tried except "SETTRGENAB". This command crashes spikeglx whether I pass a 0 or a 1 if acquisition is running. It does not crash if acquisition is not running, but rather returns "OK" via the socket regardless of whether I pass it a 0 or 1. If I don't pass anything (ie just send "SETTRGENAB") it will report an error in the console and return an error via the socket.

I'm running SpikeGLX v.20151231. I can try to look into the code myself to see what's going on, but I figure you might be able to solve it more efficiently than I.

Cheers

— Reply to this email directly or view it on GitHubhttps://github.com/billkarsh/SpikeGLX/issues/1.

billkarsh commented 8 years ago

Fix here (version 20160101): http://billkarsh.github.io/SpikeGLX/

From: Chris Wilson [mailto:notifications@github.com] Sent: Friday, February 12, 2016 10:57 AM To: billkarsh/SpikeGLX SpikeGLX@noreply.github.com Subject: [SpikeGLX] Crash on SETTRGENAB (#1)

Hi Bill,

I've been using SGLX and loving it for the most part. I wanted to bring a bug in the command server to your attention. I can get everything working that I've tried except "SETTRGENAB". This command crashes spikeglx whether I pass a 0 or a 1 if acquisition is running. It does not crash if acquisition is not running, but rather returns "OK" via the socket regardless of whether I pass it a 0 or 1. If I don't pass anything (ie just send "SETTRGENAB") it will report an error in the console and return an error via the socket.

I'm running SpikeGLX v.20151231. I can try to look into the code myself to see what's going on, but I figure you might be able to solve it more efficiently than I.

Cheers

— Reply to this email directly or view it on GitHubhttps://github.com/billkarsh/SpikeGLX/issues/1.

billkarsh commented 8 years ago

Remote call to setTrgEnable routes from cmdSrv to run to graphsWindow. The latter needed to be a queued call. While retesting, noticed that setRunName would pass a _g_t decorated name to configCtl as is. Now that name is stripped. This enables graphsWindow to properly handle _g_t tags. Fixes made to current master, tagged as Release_v20160101.

c-wilson commented 8 years ago

So far so good for me, thanks