billkarsh / SpikeGLX

SpikeGLX recording system GUI [Neuropixels NI]
Other
83 stars 29 forks source link

MATLAB SDK StartRun crashes SpikeGLX #4

Closed brykko closed 6 years ago

brykko commented 6 years ago

Hi Bill,

I have successfully performed a number of operations using the MATLAB API, but when I try using the StartRun command, this causes SpikeGLX to crash every time (the generic "SpikeGLX has stopped working" dialog appears). If I start SpikeGLX running manually, then I can use StopRun without any problems. I'm working with MATLAB R2017a and SpikeGLX v20171101-phase3A. Might I be using the API commands incorrectly, or is this a bug?

Thanks, Rich

billkarsh commented 6 years ago

Hi Rich,

I confirm your bug with MATLAB API StartRun. The fix will be included in the next release (a few days hence).

The next release will include several improvements to the graph filters, which are inspired by the slow graph performance of BinMax you reported.

I am closing this issue. Thanks for improving SpikeGLX. Bill

From: Rich Gardner [mailto:notifications@github.com] Sent: Tuesday, March 27, 2018 11:13 AM To: billkarsh/SpikeGLX SpikeGLX@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [billkarsh/SpikeGLX] MATLAB SDK StartRun crashes SpikeGLX (#4)

Hi Bill,

I have successfully performed a number of operations using the MATLAB API, but when I try using the StartRun command, this causes SpikeGLX to crash every time (the generic "SpikeGLX has stopped working" dialog appears). If I start SpikeGLX running manually, then I can use StopRun without any problems. I'm working with MATLAB R2017a and SpikeGLX v20171101-phase3A. Might I be using the API commands incorrectly, or is this a bug?

Thanks, Rich

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/billkarsh/SpikeGLX/issues/4, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGxB0C3TPQ9GjKFRbsKU6BZPF0bchK0Lks5tilb1gaJpZM4S9HSm.

brykko commented 6 years ago

Great to hear there will be a fix soon, that will be really useful.

I've noticed a couple more (less critical) problems with the MATLAB SDK, which I'll raise in separate issues.

billkarsh commented 6 years ago

Hi Rich,

You can list the problems en masse. Sooner is better. Thanks, Bill


From: Rich Gardner [notifications@github.com] Sent: Wednesday, March 28, 2018 6:07 AM To: billkarsh/SpikeGLX Cc: Karsh, Bill; Comment Subject: Re: [billkarsh/SpikeGLX] MATLAB SDK StartRun crashes SpikeGLX (#4)

Great to hear there will be a fix soon, that will be really useful.

I've noticed a couple more (less critical) problems with the MATLAB SDK, which I'll raise in separate issues.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/billkarsh/SpikeGLX/issues/4#issuecomment-376833279, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGxB0Ey35e6FiF1KuvQyLxYPBealANM3ks5ti2D6gaJpZM4S9HSm.

brykko commented 6 years ago

OK sure –

1) MATLAB SpikeGL objects appear to expire after a few seconds. I guess there's no problem with that per se, but if I attempt to call a method of an expired SpikeGL object, this causes MATLAB to hang indefinitely.

2) The "GetRunName" method throws an error, apparently because of an incorrect field name in the MATLAB code.

billkarsh commented 6 years ago

Hi Rich,

Good detective work. I confirm both of these problems. The fixes will be rolled into the next release.

On the MATLAB client side, stale handles will now automatically reconnect if the socket has timed out. The only penalty is that a warning message is sent to the Command Window if that happened, but it does not interrupt a running script. You can set a longer timeout in the SpikeGLX Command Server Dialog if that behavior is problematic.

I will close these issues.

From: Rich Gardner [mailto:notifications@github.com] Sent: Wednesday, March 28, 2018 1:40 PM To: billkarsh/SpikeGLX SpikeGLX@noreply.github.com Cc: Karsh, Bill karshb@janelia.hhmi.org; Comment comment@noreply.github.com Subject: Re: [billkarsh/SpikeGLX] MATLAB SDK StartRun crashes SpikeGLX (#4)

OK sure –

  1. MATLAB SpikeGL objects appear to expire after a few seconds. I guess there's no problem with that per se, but if I attempt to call a method of an expired SpikeGL object, this causes MATLAB to hang indefinitely.

  2. The "GetRunName" method throws an error, apparently because of an incorrect field name in the MATLAB code.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/billkarsh/SpikeGLX/issues/4#issuecomment-376972661, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGxB0KmknOsYXLPDjB2_TCqNs8aoSL-Wks5ti8rVgaJpZM4S9HSm.

billkarsh commented 6 years ago

Fixed. Closing issue.