Image loading issue - Half images

billmalarky / react-native-image-cache-hoc

React Native Higher Order Component that adds advanced caching functionality to the react native Image component.

MIT License

287 stars 53 forks source link

Image loading issue - Half images #22

Open jaaahh opened 6 years ago

jaaahh commented 6 years ago

simulator screen shot - iphone 7 plus - 2018-04-15 at 01 16 53

images are showing when its not fully loaded.

mmamoyco commented 6 years ago

+1, showing half of image.

schumannd commented 6 years ago

I had a similar issue where image would be displayed only have loaded or with some weird artifacts. They would be cached and stay this way until app relaunch. Any Idea how this happens?

billmalarky commented 6 years ago

Is this intermittent or can it be recreated with the same image file repeatedly?

On Tue, May 8, 2018, 3:45 AM David Schumann notifications@github.com wrote:

I had a similar issue where image would be displayed only have loaded or with some weird artifacts. They would be cached and stay this way until app relaunch. Any Idea how this happens?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/billmalarky/react-native-image-cache-hoc/issues/22#issuecomment-387315037, or mute the thread https://github.com/notifications/unsubscribe-auth/ABxTU5vgzT0SWx4IW2sw2ChG-IoIF5c0ks5twU0bgaJpZM4TVNe5 .

schumannd commented 6 years ago

I was not able to reproduce this in any way. Has only occurred 2-3 times since we have used it. So 0.1% of the time?

Also there is nothing special about the images it occurs with. An arary of similar images (dimensions all about 1200 x 500) all hosted on S3 is displayed. In one instance one image was affected (similar to OPs image, image was party loaded and rest of image was white), in another one 2 were affected. In that case some weird graphical errors were visible. (thin colorful squiggly lines)

billmalarky commented 6 years ago

This is probably an issue related to the RNfetchblob (https://github.com/joltup/react-native-fetch-blob) dependency if I had to guess. Looks like react-native-image-cache-hoc is on the latest version of RNfetchblob so upgrading won't patch.

For what it's worth, so long as the image was downloaded to the cache (ie you didn't supply a permanent={true} prop), sooner or later the broken image will be garbage collected from the cache and re-downloaded which solves the problem in the case that something just intermittently went wrong during the download process.