fixed android 6.0+ fetch HEAD network error bugs

billmalarky / react-native-image-cache-hoc

React Native Higher Order Component that adds advanced caching functionality to the react native Image component.

MIT License

287 stars 53 forks source link

fixed android 6.0+ fetch HEAD network error bugs #25

Open oneroundseven opened 6 years ago

oneroundseven commented 6 years ago

https://github.com/facebook/react-native/issues/18440

coveralls commented 6 years ago

Coverage decreased (-1.4%) to 92.114% when pulling daf07347b98779f9e82b00b891bd34606daf943d on oneroundseven:master into a2880e9a0e98fb5379fc44ae3bf6ff3496c56fa9 on billmalarky:master.

billmalarky commented 6 years ago

Looks like there are linting errors. To problem I can quickly solve those with my own commit.

The larger issue here, is this is not a solution to the bug.

A patch will need to be applied in this function: https://github.com/billmalarky/react-native-image-cache-hoc/blob/master/lib/FileSystem.js#L186-L227

For what it's worth, you will not run into this issue so long as the images you are using for CacheableImage have an extension in the url like .jpg/.png.gif etc.

oneroundseven commented 6 years ago

but some server image url not has the .jpg/.png ...
and the server return fetch is correct, but fetch not correct call back with the issue error