Closed mend-for-github-com[bot] closed 1 year ago
This PR contains the following updates:
^3.9.1
^5.0.0
By merging this PR, the below issues will be automatically resolved and closed:
This PR contains the following updates:
^3.9.1->^5.0.0By merging this PR, the below issues will be automatically resolved and closed:
Release Notes
testing-library/eslint-plugin-testing-library
### [`v5.0.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v5.0.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.12.4...v5.0.0) ##### BREAKING CHANGES - **prefer-query-by-disappearance:** `prefer-query-by-disappearance` is now enabled by default in all configs - **prefer-presence-queries:** `prefer-presence-queries` is now enabled by default in all configs - **no-wait-for-snapshot:** `no-wait-for-snapshot` is now enabled by default in all configs - **no-wait-for-side-effects:** `no-wait-for-side-effects` is now enabled by default in all configs - **no-wait-for-multiple-assertions:** `no-wait-for-multiple-assertions` is now enabled by default in all configs - **no-render-in-setup:** `no-render-in-setup` is now enabled by default in the Angular, React & Vue configs - **no-unnecessary-act:** `no-unnecessary-act` is now enabled by default in the React config - **no-debug:** `no-debug` is now called `no-debugging-utils` - Requires Node@^12.22.x || ^14.17.x || >=16.x You can follow the [migration guide to v5](https://togithub.com/testing-library/eslint-plugin-testing-library/blob/main/docs/migration-guides/v5.md). ##### Features - support ESLint v8 ([#465](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/465)) ([5b03edb](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/5b03edb47e7f1ede556e69baadbe0b0f0304d8af)) ### [`v4.12.4`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.12.4) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.12.3...v4.12.4) ##### Reverts - "ci: fix node 16 to 16.8" ([#482](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/482)) ([fb2740c](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/fb2740c76d2f726d9ca08105b52628adff8d9141)) ### [`v4.12.3`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.12.3) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.12.2...v4.12.3) ##### Bug Fixes - **prefer-explicit-assert:** check property existence ([#476](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/476)) ([1949a93](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/1949a93fbb501612f85026f1aa1e929f8f0b95bc)) ### [`v4.12.2`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.12.2) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.12.1...v4.12.2) ##### Bug Fixes - **prefer-find-by:** handle different spacing correctly for autofix ([#472](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/472)) ([9624a44](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/9624a44b73f704012b941fd3d4109940a9349588)) ### [`v4.12.1`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.12.1) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.12.0...v4.12.1) ##### Bug Fixes - **dependencies:** bump [@typescript-eslint/experimental-utils](https://togithub.com/typescript-eslint/experimental-utils) ([#461](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/461)) ([fd5f057](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/fd5f0576ec5a81a75e85a7bbbe870bef41285683)) ### [`v4.12.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.12.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.11.0...v4.12.0) ##### Features - **prefer-find-by:** report presence assertions ([#450](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/450)) ([94758f1](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/94758f14b47ffadbc54c844e346c1a8477dbd3f0)), closes [#420](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/420) ### [`v4.11.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.11.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.10.1...v4.11.0) ##### Features - **prefer-explicit-assert:** add an option to toggle the matching of findBy queries ([#452](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/452)) ([172a5ac](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/172a5acefeeac7c93d29eb169bdc767de9baac30)), closes [#449](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/449) ### [`v4.10.1`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.10.1) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.10.0...v4.10.1) ##### Bug Fixes - **no-unnecessary-act:** report everything that's reported in non-strict ([#423](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/423)) ([840763d](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/840763d3115d077e14ba42cc4b6e13aafa722757)), closes [#416](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/416) ### [`v4.10.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.10.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.9.3...v4.10.0) ##### Features - **prefer-explicit-assert:** report on `findBy*` queries too ([#421](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/421)) ([c92e7ff](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/c92e7ffb9156efcd94846c56ed3191282e2bdc6e)), closes [#409](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/409) ### [`v4.9.3`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.9.3) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.9.2...v4.9.3) ##### Bug Fixes - **no-unnecessary-act:** fix false positives when `isStrict` option is set to `false` ([#418](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/418)) ([e0da981](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/e0da981c19dda9545540d3540ca4dcc6fdb58bb6)) ### [`v4.9.2`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.9.2) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.9.1...v4.9.2) ##### Bug Fixes - **prefer-user-event:** prevent crash with custom `createEvent` function ([#422](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/422)) ([4808bca](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/4808bca6091ca0e5208660b867b44796f053c24e)), closes [#405](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/405) ### [`v4.9.1`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.9.1) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.9.0...v4.9.1) ##### Bug Fixes - **prefer-query-by-disappearance:** fix rule name ([#410](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/410)) ([9cf72b2](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/9cf72b20191d57097327fcfb2177f25740037fe9)) ### [`v4.9.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.9.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.8.0...v4.9.0) ##### Features - **no-unnecessary-act:** add `isStrict` option ([#404](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/404)) ([b68d66b](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/b68d66b88209a22f81b365385d88b8f342d5e937)), closes [#382](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/382) ### [`v4.8.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.8.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.7.0...v4.8.0) ##### Features - new `prefer-query-by-disappearance` rule ([#402](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/402)) ([b94437a](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/b94437ae747f2458b0aada5fb3540783aae1c237)), closes [#399](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/399) ### [`v4.7.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.7.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.6.0...v4.7.0) ##### Features - **prefer-user-event:** add support for `fireEvent` as function ([#398](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/398)) ([0c11511](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/0c11511f958a511993007b98d0cd7ae37157eefd)), closes [#261](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/261) ### [`v4.6.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.6.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.5.1...v4.6.0) ##### Features - **prefer-screen-queries:** detect render in wrappers ([#388](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/388)) ([b92132d](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/b92132d6d558fa809659e53937c4d4f1958dcc5e)), closes [#367](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/367) ### [`v4.5.1`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.5.1) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.5.0...v4.5.1) ##### Bug Fixes - **dependencies:** bump [@typescript-eslint/experimental-utils](https://togithub.com/typescript-eslint/experimental-utils) ([eb85374](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/eb85374ef2287b3b0a719a5e848dd78b20f6d613)) ### [`v4.5.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.5.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.4.0...v4.5.0) ##### Features - add compatibility for Node 16 ([#350](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/350)) ([ef03394](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/ef03394cb9d6960d896b052887b91645ac0c57f6)) ### [`v4.4.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.4.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.3.0...v4.4.0) ##### Features - **no-debug:** support more debugging functions ([#357](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/357)) ([b2579bb](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/b2579bb606034c0cbb8c3a050daadffc9440a35c)) ### [`v4.3.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.3.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.2.1...v4.3.0) ##### Features - new `no-unnecessary-act` rule ([#365](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/365)) ([88416b2](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/88416b27afbef135e4f6a491695bb7fcc93bd8ed)), closes [#259](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/259) ### [`v4.2.1`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.2.1) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.2.0...v4.2.1) ##### Bug Fixes - **await-async-query:** get correct Identifier related to CallExpression ([#374](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/374)) ([816df6e](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/816df6e462fa51f081725a675492ec66b69dcbac)), closes [#359](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/359) ### [`v4.2.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.2.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.1.2...v4.2.0) ##### Features - **no-wait-for-side-effects:** report `render` usage in `waitFor` ([#363](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/363)) ([9f5de30](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/9f5de305bbc570abb41261d26fabba2568e3c9fb)) ### [`v4.1.2`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.1.2) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.1.1...v4.1.2) ##### Bug Fixes - **no-wait-for-side-effects:** report implicit return in arrow functions ([#352](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/352)) ([0d105df](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/0d105df745f8a4252596da878ea39ecc4e8aa4b1)) ### [`v4.1.1`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.1.1) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.1.0...v4.1.1) ##### Bug Fixes - **no-debug:** allow console.debug() ([#349](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/349)) ([43a14a2](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/43a14a29244a2985c0b080a1a62e93be4c1a2bc0)), closes [#327](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/327) ### [`v4.1.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.1.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.0.2...v4.1.0) ##### Features - new shared setting for restricting Aggressive Queries Reporting: `testing-library/custom-queries` ([#344](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/344)) ([a8d2017](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/a8d20170df43caf0a53842f84880446569fb62ec)), closes [#335](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/335) - new `"off"` option for all shared settings to disable related Aggressive Reporting mechanism ([#344](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/344)) ([a8d2017](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/a8d20170df43caf0a53842f84880446569fb62ec)), closes [#335](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/335) ### [`v4.0.2`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.0.2) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.0.1...v4.0.2) ##### Bug Fixes - **prefer-screen-queries:** avoid reporting custom queries ([#342](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/342)) ([1c4391c](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/1c4391ccc91d2dd936041a0bbbe3c33abb36ee7a)), closes [#340](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/340) ### [`v4.0.1`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.0.1) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v4.0.0...v4.0.1) ##### Bug Fixes - **no-node-access:** skip reporting files without Testing Library import ([#338](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/338)) ([19947ef](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/19947ef542e679c6cdeb84a9140b8fd4e00af20e)), closes [#334](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/334) ### [`v4.0.0`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v4.0.0) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v3.10.2...v4.0.0) ##### Overview `eslint-plugin-testing-library` v4 brings the new Aggressive Reporting (an advanced mechanism to drastically improve reporting things related to Testing Library), 7 new rules, Shareable Configs updates, more consistent and flexible detection, and tons of bug fixes. You can follow this [migrating to v4 guide](https://togithub.com/testing-library/eslint-plugin-testing-library/blob/v4.0.0/docs/migrating-to-v4-guide.md). ##### BREAKING CHANGES - Minimum ESLint version required is v7.5. Support from v5.X to v7.5 has been dropped - `recommended` Shareable Config has been renamed to `dom` - `no-promise-in-fire-event` rule enabled in `dom`, `angular`, `react` and `vue` Shareable Configs - `no-wait-for-empty-callback` rule enabled in `dom`, `angular`, `react` and `vue` Shareable Configs - `prefer-screen-queries` rule enabled in `dom`, `angular`, `react` and `vue` Shareable Configs - `no-container` rule enabled in `angular`, `react` and `vue` Shareable Configs - `no-node-access` rule enabled in `angular`, `react` and `vue` Shareable Configs - `render-result-naming-convention` rule enabled in `angular`, `react` and `vue` Shareable Configs - `no-debug` rule changed from "warning" to "error" in `angular`, `react` and `vue` Shareable Configs - **prefer-explicit-assert:** option `customQueryNames` has been removed - **no-debug:** option `renderFunctions` has been removed - **no-render-in-setup:** option `renderFunctions` has been removed ##### Bug Fixes - all rules detect things related to Testing Library (wrappers, variable references, custom imports, renamed utils) better and more consistently - **await-async-query:** detect wrappers around async queries properly ([#260](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/260)) - **await-async-utils:** detect wrappers around async utils properly ([#263](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/263)) - **await-fire-event:** detect wrappers around fire event properly ([#265](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/265)) - **no-await-sync-events:** report `type` and `keyboard` methods with 0 delay ([#302](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/302)) - **no-debug:** detect wrappers around `debug` properly ([#295](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/295)) - **prefer-screen-queries:** ignore queries coming from non-reportable renders - **prefer-screen-queries:** improve error message ([#320](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/320)) ##### Features - new Aggressive Reporting mechanism for detecting Testing Library imports, renders, utils, and queries ([#237](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/237), [#252](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/252), [#260](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/260)) - new rule `no-container` ([#177](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/177), [#295](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/295)) - new rule `render-result-naming-convention` ([#200](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/200), [#280](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/280), [#282](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/282)) - new rule `prefer-user-event` ([#192](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/192), [#251](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/251)) - new rule `no-promise-in-fire-event` ([#180](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/180), [#266](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/266)) - new rule `no-wait-for-side-effects` ([#196](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/196), [#300](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/300)) - new rule `no-node-access` ([#190](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/190), [#237](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/237)) - new rule `no-wait-for-multiple-assertions` ([#189](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/189), [#301](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/301)) - new shared setting `testing-library/utils-module` ([#239](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/239)) - new shared setting `testing-library/custom-renders` ([#280](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/280), [#282](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/282)) ##### Contributors Huge thanks to [@nickmccurdy](https://togithub.com/nickmccurdy) [@thebinaryfelix](https://togithub.com/thebinaryfelix) [@timdeschryver](https://togithub.com/timdeschryver) [@gndelia](https://togithub.com/gndelia) [@renatoagds](https://togithub.com/renatoagds) [@MichaelDeBoey](https://togithub.com/MichaelDeBoey) [@thomaslombart](https://togithub.com/thomaslombart) for your contributions of all kind! v4 wouldn't be possible without you ❤️ ### [`v3.10.2`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v3.10.2) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v3.10.1...v3.10.2) ##### Bug Fixes - **no-await-sync-events:** add exception for userEvent.keyboard ([4d5b422](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/4d5b422348d119de2aaa8c0ec6cbbd5ba935bae7)) ### [`v3.10.1`](https://togithub.com/testing-library/eslint-plugin-testing-library/releases/tag/v3.10.1) [Compare Source](https://togithub.com/testing-library/eslint-plugin-testing-library/compare/v3.10.0...v3.10.1) ##### Bug Fixes - **prefer-explicit-assert:** handle valid getBy\* without expect ([#257](https://togithub.com/testing-library/eslint-plugin-testing-library/issues/257)) ([b289638](https://togithub.com/testing-library/eslint-plugin-testing-library/commit/b289638de1cbdaaed53bf8f78c90bd69fb1e6b9c))