billpull / knockout-bootstrap

A plugin that adds custom bindings for twitter bootstrap objects such as tooltips and popovers.
233 stars 69 forks source link

Knockout 3 #22

Open nodrog opened 10 years ago

nodrog commented 10 years ago

hello

Does anyone have any ideas on knockout bootstrap working with knockout 3

I am getting errors on the progress bar (i only use this at the moment)

Uncaught Error: You cannot apply bindings multiple times to the same element.

any thoughts?

thanks

billpull commented 10 years ago

can you post a jsfiddle/jsbin reproducing the issue?

rlvandaveer commented 10 years ago

I see that this issue is open but the merge confuses me. Is this open? I'm having this exact same error. I'm using Durandal which uses KO to dynamically compose MVVM. I'm assuming the issue relates to this line of the progress binding:

koObject.applyBindingsToDescendants(viewModel, $element[0]);

Now I believe that if you apply bindings to descendants that you are supposed to tell KO not to apply bindings using:

return { controlsDescendantBindings: true };

While adding this line does cause the error to not appear, it doesn't cause the progress bar to update along with it's bound observable either.

billpull commented 10 years ago

Yea still havent had time to upgrade this lib to knockout 3 would really like to get it done but can't nail down what is causing that error.

mika76 commented 9 years ago

Hey Bill, any news on this?

billpull commented 9 years ago

To be honest its been awhile since ive worked on or used this project so doubtful I would personally get around to upgrading this to Ko3