Fix bug in popover preventing bind to viewmodel properties.

billpull / knockout-bootstrap

A plugin that adds custom bindings for twitter bootstrap objects such as tooltips and popovers.

233 stars 69 forks source link

Fix bug in popover preventing bind to viewmodel properties. #51

Closed mikehaas763 closed 10 years ago

mikehaas763 commented 10 years ago

This was caused by 4722c3a6c392e1d45a6871599037bae91c490aca

mikehaas763 commented 10 years ago

So I fixed the problem with binding in the template to the viewmodel. Hopefully it didn't create a problem with anything else. @billpull would you be against setting up a test runner and begin to get some tests going? I'm thinking karma+jasmine or mocha+chai.

billpull commented 10 years ago

sounds good to me I think @ciuliot had mentioned using https://coveralls.io/

ciuliot commented 10 years ago

I have pretty good experience with phantomjs + vows.js + instanbul.js and reporting on coveralls.io however that's just personal preference. I didn't found any service for publishing jsHint/jsLint reports, anyone knows about something like that?

mikehaas763 commented 10 years ago

Ooops, looks like koObject and not ko is used in this lib. ko must be available globally in the examples page because it was working there. Sending an update to use koObject now.

mikehaas763 commented 10 years ago

@ciuliot I don't think vows is a good pick for this lib. I don't have any experience actually using vows outside of just looking in to it. Vows is "highly integrated with node.js". With a DOM library like this, it's actually really important to run it against a DOM implementation such as phantomjs. Have I made any wrong assumptions about vows so far?

ciuliot commented 10 years ago

@mikehaas763 not sure if we are talking about same lib, one that I'm referencing is http://vowsjs.org/ and it's about style how you write unit tests. I'm using it on my projects with combination with should.js (https://github.com/visionmedia/should.js/).

Just to split it up, my understanding is that we will need:

Headless webkit: zombie,js, phantom.js, karma.js etc.
Unit test framework: vows.js, jasmine.js, mocha.js, karma.js, etc.
Assertion library: should.js, chai.js, built-in Node.js assert and usually unit test framework comes with own as well
Coverage tool: istanbul.js, jscover, blanket.js, jscoverage etc.

I think any combination of those is fine as long as person writing tests has experience with it. I'm usually sticking with phantom + vows + should + istanbul but it's up to everybody's taste :)

mikehaas763 commented 10 years ago

@ciuliot Yep that's the vows I was talking about. I realize that https://github.com/flatiron/vows/issues/60 is an old issue but that's where my thinking is coming from around vows. So if vows.js is still truly "highly tied to node.js in its architecture" then you must be using a custom module to get vows.js to run on a headless browser?

Like I said, I've never actually used vows more than just to looking at it as one of my options for testing so I may be making some incorrect assumptions here.

ciuliot commented 10 years ago

@mikehaas763 I think you are right, vows seems to be more oriented on Node.js server side. For client side it seems that jasmine or mocha are offering similar approach.