search

billpull / knockout-bootstrap

A plugin that adds custom bindings for twitter bootstrap objects such as tooltips and popovers.
233 stars 69 forks source link

Fix memory leaks #68

Closed davhdavh closed 9 years ago

davhdavh commented 9 years ago

The various elements are not cleaned up after using

billpull commented 9 years ago

Looks like this introduced some JSHint errors. The code looks good to me so if you can fix the linting I will merge it.

davhdavh commented 9 years ago

I cant seem to extract the jshint log from Travis, can you send me the warnings?

billpull commented 9 years ago

I think this is the only problem

153 Expected an assignment or function call and instead saw an expression.

oddly enough I cant seem to find the output in travis either I had to run locally

davhdavh commented 9 years ago

Done