search

billpull / knockout-bootstrap

A plugin that adds custom bindings for twitter bootstrap objects such as tooltips and popovers.
232 stars 69 forks source link

Popover does not work with custom template source #8

Closed AndersMalmgren closed 10 years ago

AndersMalmgren commented 11 years ago

http://jsfiddle.net/GgpGA/

billpull commented 11 years ago

yea currently the template for the popover has to be in the DOM it matches the template argument to an id on the page and gets the HTML for the popover from there.

AndersMalmgren commented 11 years ago

I did a quick test (Not all popover features are there) but the template part works

http://jsfiddle.net/LRvWV/

edit: Fixed a bug with template stoppingto work if reopen popover http://jsfiddle.net/LRvWV/2

AndersMalmgren commented 11 years ago

Fixed close button

http://jsfiddle.net/LRvWV/5/

zongweil commented 10 years ago

Took the ideas of @AndersMalmgren and extended it to the current version of master. See the pull request above.

http://jsfiddle.net/zongweil/42mFj/1/