search

billputer / go-namecheap

A Go library for using the Namecheap API
MIT License
49 stars 28 forks source link

Switched to POST requests and added DomainRenew #11

Closed jameshartig closed 6 years ago

jameshartig commented 6 years ago

Fixes #5

Typically I wouldn't include 2 separate commits in a PR but since DomainRenew is small and depends on the POST commit I included it since a separate PR would fail. I can remove it if you want.

I removed the special handling for commas and verified using the sandbox that it's no longer needed. We also can use + in the phone number field despite it translating to %2B.

jameshartig commented 6 years ago

@billputer Anything I need to change to get this merged?

jameshartig commented 6 years ago

Closing so I can make a separate branch