billputer / go-namecheap

A Go library for using the Namecheap API
MIT License
49 stars 28 forks source link

Switched to POST requests and added DomainRenew #14

Closed jameshartig closed 6 years ago

jameshartig commented 6 years ago

Fixes #5

Typically I wouldn't include multiple commits in a PR but since these depend on the changes to POST if I included them in a separate PR it would fail. I can remove them if you want.

I removed the special handling for commas and verified using the sandbox that it's no longer needed. We also can use + in the phone number field despite it translating to %2B.

billputer commented 6 years ago

LGTM. Thanks for this!