billrobo / gdatacopier

Automatically exported from code.google.com/p/gdatacopier
0 stars 0 forks source link

4 Letter TLD not valid in RE match #63

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Using a hosted domain with a TLD that's greater than 4 characters with gls.  
.coop for example

What is the expected output? What do you see instead? I expect to see the 
output of the gls command, instead see: "Usernames must be provided as your 
full Gmail address, hosted domains included."

What version of the product are you using? On what operating system?  2.1.1 on 
windows xp

Please provide any additional information below.

I corrected the issue by changing the is_email def:
"if 
re.match("^.+\\@(\\[?)[a-zA-Z0-9\\-\\.]+\\.([a-zA-Z]{2,3}|[0-9]{1,3})(\\]?)$", 
email) != None:"
To accept a 4 letter TLD with:
"if 
re.match("^.+\\@(\\[?)[a-zA-Z0-9\\-\\.]+\\.([a-zA-Z]{2,4}|[0-9]{1,3})(\\]?)$", 
email) != None:"

Original issue reported on code.google.com by daniel1...@gmail.com on 28 Jul 2010 at 9:43

GoogleCodeExporter commented 9 years ago
Thanks for the patch.

Original comment by devraj on 28 Jul 2010 at 10:52

GoogleCodeExporter commented 9 years ago
What version of Gdatacopier are you using?

Original comment by devraj on 18 Aug 2010 at 12:50

GoogleCodeExporter commented 9 years ago
Fixed regex. To be released as 2.1.2

Original comment by devraj on 18 Aug 2010 at 1:16