billsedison / vscode-gitlens

Supercharge the Git capabilities built into Visual Studio Code — Visualize code authorship at a glance via Git blame annotations and code lens, seamlessly navigate and explore Git repositories, gain valuable insights via powerful comparison commands, and so much more
http://gitlens.amod.io
MIT License
0 stars 17 forks source link

Fixed: Commit Search will not use __lastSearch for next searches #133

Closed cagdas001 closed 5 years ago

cagdas001 commented 5 years ago

https://gitlab.com/aggregated-git-diff/aggregated-git-diff-bug-bash/issues/110

After doing a successful search, its returning the same (the previous) results for next searches.

Steps to Reproduce

  1. Clone/checkout the tc-dev-merge-to-9.4.1 branch.
  2. Run
    npm install
    npm run build
  3. Open the root directory of project with VSCode.
  4. Start debugging (Press F5)
  5. Open the Command Palette by pressing Ctrl+Shift+P, and select the GitLens: Search Commits command.
    • All commits should be listed on the left panel.
  6. Enter a keyword in the enter search text field, and click Search.
    • The correct search results (related to keyword) should be shown on the left panel.
  7. Delete the keyword (i.e. clear the enter search text field) and Search again.
  8. Check the results.

Expected Result

Correct results should be returned.

Actual Result

The previous search results are being returned for next searches.

Screencast

2019-02-27_00-38-54