search

billthefarmer / currency

Android currency conversion
https://billthefarmer.github.io/currency
GNU General Public License v3.0
86 stars 32 forks source link

Correct currency symbol position #47

Closed sinus-x closed 5 years ago

sinus-x commented 5 years ago

Currently all currency symbols are being displayed before the numerical value. As this is valid for some currencies (pound, dollar), some have it the other way - czech crowns (Kč), polish zloty (zl) and others.

I think it shouldn't be too hard to add another boolean array to specify symbol position - am I right?

billthefarmer commented 5 years ago

I originally cribbed the layout of this app from the excellent XE Currency app. I just checked it out again, and although it has been updated since, they get it wrong as well, if you are correct.

sinus-x commented 5 years ago

It seems that XE is Canada-based company, so I wouldn't be surprised they got it wrong, considering that both Canada and US have the symbol before value and they may have not seen other currency representations.

The currencies that have symbol first are eur (€), usd ($), jpy (¥), gbp (£), (? ...)

and those which have number (and space) first: bgn (лв), czk (Kč), dkk (kr), huf (Ft), pln (zł), ron (lei), sek (kr), chf (Fr/SFr), nok (kr), hrk (kn), ...

billthefarmer commented 5 years ago

I did some searching on this. Apparently the position of the currency symbol should be where a user using the locale the device is set to would expect it, not where a user of that currency would expect it.

sinus-x commented 5 years ago

where a user would expect it

Well, that makes some sence. I personally would expect it in a spot where it should be (eg. where the state having the currency puts it), however, this may be the thing where two approaches clash, both with valid arguments.

If you don't want to put your time and effort into this, I guess you can mark it as Won't fix.