search

billthefarmer / diary

Android personal diary - forked from http://git.savannah.gnu.org/cgit/diary.git
https://billthefarmer.github.io/diary
GNU General Public License v3.0
276 stars 58 forks source link

[Bromite incompatibility?] Fixed: Erroneous attribution due to Markdown change #179

Closed midaspt closed 3 years ago

midaspt commented 3 years ago

Ever since I replaced the default Android webview with Bromite (from https://www.bromite.org/, via the Webview Manager Magisk module from https://t.me/androidacy/243) on my devices (which, other than Magisk, were already running the RessurectionRemix custom ROM), Diary has this bug were day entries will appear blank and only after pressing the edit button will I be able to see their content.

If I go to my Diary folder with a file manager, I can still see all my notes there -- and I'm also able to edit them with another text editor -- so this is only a display bug.

As it is, and although I love Diary for its simplicity and transparency, I'll have to abandon it and search for another markdown capable editor.

billthefarmer commented 3 years ago

I would turn that on it`s head and suggest that bromite webview is incompatable with Diary. Quote from bromitewebview README:> PLEASE NOTE SOME APPS WON'T WORK WITHOUT GOOGLE WEBVIEW. I can't fix that and any issues on it will be closed and ignored.Sent from my Galaxy

billthefarmer commented 3 years ago

I have been unable to find any documentation whatsoever on the bromite webview to find out what parts of the Webview API it supports, if any. So I couldn't fix it, even if it were possible.

midaspt commented 3 years ago

Thanks for your consideration and work. 👍🏽

Just for the sake of it, have you seen the Bromite wiki at https://github.com/bromite/bromite/wiki?

midaspt commented 2 years ago

Hi.

Turns out, after recently rechecking this issue in Diary's latest version, I was wrong in attributing it to Bromite...

The real culprit appears to be my use of --- (Horizontal line) at the start of all my notes. If I remove this MD markup, Diary behaves as expected.

I use --- as shorthand for opening and closing notes because it prevents confusion when merging notes, especially multiple or long ones.

Maybe you could re-open this issue or advise.

Thank you.

billthefarmer commented 2 years ago

One of the commonmark extensions requested is YAML front matter, which takes the form...

---
what: ever
---

So if you start an entry with a horizontal line with three dashes, ---, the whole entry will be assumed to be interminable front matter. That was added in version 1.78. However, if you use four dashes, ----, it will be interpreted as a horizontal line.

midaspt commented 2 years ago

Thank you. 😎

So, it is explained then why my notes suddenly stopped being displayed at about that same time.

I'll update the notes backup I kept and see how it goes...