billthefarmer / editor

Android simple text editor
https://billthefarmer.github.io/editor
GNU General Public License v3.0
474 stars 85 forks source link

[Bug] Search misbehaves, makes Editor crash #218

Closed GfEW closed 8 months ago

GfEW commented 9 months ago

When trying to search for closing parantheses, i. e. the search term is the single character ')', Editor misbehaves in two conditionally different ways:

This issue is reproducible in Editor version 1.90 on two different devices, one running Android 9, the other one Android 11.

billthefarmer commented 9 months ago

That's a good one, it's taken a long time for someone to find that. It appears that the search widget partially ignores open and close brackets and doesn't call the on text changed callback. I looked at the code and couldn't see how. Fixed in the next version.

GfEW commented 9 months ago

it's taken a long time for someone to find

Just being curious, how many years (roundabout) since it was introduced? o.O

EDIT: Issue got closed inadvertantly by a malfunctioning touchscreen - somewhat early I guess, hence reopened. Sorry.

billthefarmer commented 9 months ago

The version with regex search v1.07, was released on Oct 29, 2017, so 6 years.