search

billthefarmer / mididriver

Android midi driver using Sonivox EAS library
176 stars 52 forks source link

Jhindin.pull request #8

Closed jhindin closed 9 years ago

jhindin commented 9 years ago

Hi

I've introduced several changes to MidiDriver library and have created pull requeste against your 'jhindin' branch.

  1. Numeric constants replaced with literals - I believe this change may be propagated to the master branch, too
  2. Local Maven repository integration for the mididriver Android library - it is difficult to develop application using the mididriver otherwise.

  3. local.properties reinserted into .gitignore: local.properties should never be commited into the source control, as it contains developer environment details like Android SDK and NDK pathes.

    Regards,

    Joseph Hindin