billthefarmer / notes

Android notebook
https://billthefarmer.github.io/notes
GNU General Public License v3.0
83 stars 13 forks source link

Markdown links #59

Open pudah opened 4 months ago

pudah commented 4 months ago

When I tap a markdown link in Notes, it opens the linked document as expected.

If I press back, instead of going back to the document that the link was in, I am taken back to the where I was when I launched Notes. Could be the app drawer, my file manager, etc.

Would it be possible to have the back button take the user back to the note from which a link was pressed? Or at least make it a setting allowing the user to select whichever behavior works better for them?

billthefarmer commented 2 days ago

Can't reproduce that. Both the toolbar back button and the back gesture take you back to the place in the page you tapped.

pudah commented 2 days ago

Here is a screen recording demonstrating the issue

https://imgur.com/uEGO7IJ

In it I launch Notes from the home screen, click the folder icon at the top, open the file test_markdown.md, I scroll down to the bottom of that document where there is a link to another document Markdown stuff.md in the same folder. As you can see, Markdown stuff opens. When I press the back button, I am taken back to the home screen, instead of back to test_markdown.md.

The link in the file is constructed as follows:

This is a Markdown link
[Markdown stuff](Markdown%20stuff.md)

At first I thought it might be because the file Markdown stuff.md has a space in the file name. But I also tried it with a link to a different file that does not have a space in the name. Same results.

This happens on both of my devices. One is a Motorola phone running Android 12. The other is a Samsung tablet on Android 13.

billthefarmer commented 4 hours ago

The back button in the toolbar provides back navigation when following external links to the internet. It does not appear when following internal links to other notes. That is intentional. You must be using the system back button or gesture which will work the same way, but close the app when displaying a note.