updated gradles and some code

TacoTheDank commented 6 years ago

basically what the title is

updated buildTools to 28.0.2 and compileSdk to 28
compatibility with java 1.8, and changed some corresponding code (anonymous java expressions to lambdas, etc)
updated some of your README file to use better things
i didnt touch your coding style :)

all this comes to only about a 15KB increase in the release apk build

pretty good if i do say so myself

billthefarmer commented 6 years ago

I haven't seen lambda expressions in android before. Have you tested that this works on android 3 or 4, as this app supports API 11?

TacoTheDank commented 6 years ago

The java version the coding in the app uses doesn't have to do with the java version the phone supports, I'm quite sure (it just specifically states compatibility with 1.8, otherwise it'll just default to 1.7 usually). My own phone's (a Samsung Galaxy S4, AT&T (jflteatt)) java version is only 1.7 and it has no problem running apps that are built with higher versions of java. As far as I'm aware, I didn't remove any code that would affect support on those older versions, so everything should be fine with that. To specifically make the app support a version and up, you put in "minSdkVersion" under defaultConfig (example: my app's app/build.gradle).

Oh, I probably didn't state this, but 1.8 introduced lambda expressions, among lots of other stuff. That's why I was talking about that.

billthefarmer commented 6 years ago

Ok, I finally found the docs that confirm that - https://developer.android.com/studio/write/java8-support. Thank you very much.

TacoTheDank commented 6 years ago

:P

billthefarmer / tuner

updated gradles and some code #26