search

billthefarmer / tuner

Android accordion tuner
176 stars 55 forks source link

Accidentals don't adapt to dark theme #46

Closed Glitchy-Tozier closed 3 years ago

Glitchy-Tozier commented 3 years ago

This happens pretty much in every place where sharp ♯and♭show up.

Screenshots: Screenshot_20210629-224738_Tuner.jpg 20210630_073022.jpg Screenshot_20210630-073335_Tuner.jpg

By the way, you've created a really nice tuner! :)

billthefarmer commented 3 years ago

Yes that's true, it happens on my Samsung tablet. There's not a lot I can do about it as I am using the default font in all cases except for the staff display, which uses shapes. I don't know if it is a Samsung issue or an android version issue, but the characters appear to have been designed to work in both light and dark mode and are 3-D.

Glitchy-Tozier commented 3 years ago

Right, I also use a Samsung phone: Samsung Galaxy S9 Android version 10

So are you saying this doesn't happen on other phones?

billthefarmer commented 3 years ago

It doesn't happen on Motorola phones running android 7.12 or emulators running android 10 and 11. Just to prove it's generic, here's a screenshot from my tablet of an editor with text from the tuner copy to clipboard facility. It even overrides the green text.

Screenshot_20210630-123200_Editor 1

Glitchy-Tozier commented 3 years ago

♭♮♯

Oh, so you're using some kind of emojies instead of normal icons, right?

In that case, the bug makes sense to me; emojies don't adapt their colors to the system theme.

What about using actual icons that you could color according to the theme? This might even improve the styling as you wouldn't use 3d-looking accidentals with an otherwise flat app.

billthefarmer commented 3 years ago

No, I'm using the standard Unicode font that includes musical characters along with hundreds of others. Samsung are using emojis or whatever in what should be the standard font. Just to illustrate that, here's a screenshot of the above comment in my Samsung email app showing the three musical characters you included that appear as they should anywhere but on a Samsung device.

Screenshot_20210630-151350_Email 1

Glitchy-Tozier commented 3 years ago

That's unfortunate. There still is tge possibility of actually using icons, but i imagine that's not very elegant, especially with changing font-sizes.

billthefarmer commented 3 years ago

I don't intend to attempt to fix a problem caused by Samsung's dubious font.

Glitchy-Tozier commented 3 years ago

Makes sense. Closing this issue then.