search

billuraksoy / virtual_lab

0 stars 1 forks source link

error in Part 2 Earnings #108

Closed billuraksoy closed 4 years ago

billuraksoy commented 4 years ago

There seems to be multiple issues here.

  1. The conversation rate is wrong. In this example, 19*0.3 = 5.70 Screen Shot 2020-10-12 at 6 15 20 PM

  2. For this subject, the code is not pulling the numbers correctly. Screen Shot 2020-10-12 at 6 16 00 PM

mcdaij commented 4 years ago

The first part was just printing to too few decimals earlier on which made it look like it was doing the math wrong.

The second part was also a minor structural issue with the output code, now fixed. (nothing was wrong on the data entry or calculation)

In general if you could include the all_vars printout in the screenshots when posting bugs that would be a huge help.

billuraksoy commented 4 years ago

I think you figured them out already. But here are the screenshots for the all_vars printout in case there is new info to help you with this issue. Can you comment here so confirm that this is issue is fixed now?

  1. This is the case where conversation rate was the issue: Screen Shot 2020-10-13 at 8 35 09 AM

This is for the second subject (Part 2 earnings were 0) Screen Shot 2020-10-13 at 8 32 51 AM

billuraksoy commented 4 years ago

I tested the code and everything seems to be calculating correctly. I think some of the problems were caused because I was using the same computer for different subjects. I did this last testing with 4 different computers and I have not seen any issues. I have not checked the data excel sheet. I will examine the data and will open more issues if there are any. Thanks Jack!