search

billvaglienti / ProtoGen

Communications protocol generation software
MIT License
30 stars 16 forks source link

Missing dependency headers in map files #90

Closed AppliedNav closed 5 years ago

AppliedNav commented 5 years ago

When Protogen builds a map file, it fails to include dependency headers, if, for example, a packet in one source file depends on a structure in another file.

billvaglienti commented 5 years ago

Fixed in 2.18

AppliedNav commented 5 years ago

For some reason, this issue persists after 2.18 update... we should take another look at it.

AppliedNav commented 5 years ago

OK, I see what's happening (sort of). The code change you made in 2.18 redundantly adds dependency header includes for data types, but the actual issue I was reporting is not addressed. The missing dependencies I was referring to were the map headers for the independent data, which contain prototypes to the C++ functions that do the mapping/unmapping of the independent data types used.

AppliedNav commented 5 years ago

Should I create a new issue or you want to reopen this one ?

billvaglienti commented 5 years ago

I need an example that shows this failing. Send me your xml so I can figure it out.

Bill Vaglienti 541 399 7883 4207 Post Canyon Hood River OR, 97031

On Thu, Sep 5, 2019 at 10:44 AM AppliedNav notifications@github.com wrote:

Should I create a new issue or you want to reopen this one ?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/billvaglienti/ProtoGen/issues/90?email_source=notifications&email_token=ACSZMHTNNIIPDZZOQJANSHDQIFAONA5CNFSM4IPBJSWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6ACYBA#issuecomment-528493572, or mute the thread https://github.com/notifications/unsubscribe-auth/ACSZMHRKISK6R76V7LOWYHDQIFAONANCNFSM4IPBJSWA .