billw2 / pikrellcam

Raspberry Pi motion vector detection program with OSD web interface.
GNU General Public License v3.0
262 stars 70 forks source link

Python 3 compatibility in example scripts #49

Open Noctem opened 4 years ago

Noctem commented 4 years ago

Python 2 will be retired in less than 5 months, and Python 3 is apparently the default in Buster.

I'm also working on packaging this for Arch (where Python 3 has been the default for nearly a decade), and this would be one less thing that I'd need to patch.

Note that I haven't tested these yet because I'm not currently using them, and I'm working on some other things, but these were all the incompatibilities I noticed from reading the code, and as far as I know everything should still work with Python 2.

P.S. I'd like to speak to you about some things regarding the Arch packaging, is there a good way for me to contact you? Feel free to email me at the address in my profile if that's your preferred method and you'd rather not share your address here.

billw2 commented 4 years ago

Thanks for the python script patches, I'll test them and apply if no problem.

You can contact me via my email at the top of the pikrellcam .c source files.

On Mon, 12 Aug 2019 16:56:54 -0700 David Christenson notifications@github.com wrote:

Python 2 will be retired in less than 5 months, and Python 3 is apparently the default in Buster.

I'm also working on packaging this for Arch (where Python 3 has been the default for nearly a decade), and this would be one less thing that I'd need to patch.

Note that I haven't tested these yet because I'm not currently using them, and I'm working on some other things, but these were all the incompatibilities I noticed from reading the code, and as far as I know everything should still work with Python 2.

P.S. I'd like to speak to you about some things regarding the Arch packaging, is there a good way for me to contact you? Feel free to email me at the address in my profile if that's your preferred method and you'd rather not share your address here. You can view, comment on, or merge this pull request online at:

https://github.com/billw2/pikrellcam/pull/49

-- Commit Summary --

  • Python 3 compatibility

-- File Changes --

M scripts-dist/ds18b20.py (21)
M scripts-dist/example-motion-detects-fifo (35)
M scripts-dist/example-motion-events (13)
M scripts-dist/example-motion-send-alarm1 (5)
M scripts-dist/example-motion-send-alarm2 (12)
M scripts-dist/pkc-alarm (6)
M scripts-dist/pkc-motion (16)
M scripts-dist/pkc-reboot (18)
M scripts-dist/pkc-recv (2)

-- Patch Links --

https://github.com/billw2/pikrellcam/pull/49.patch https://github.com/billw2/pikrellcam/pull/49.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/billw2/pikrellcam/pull/49