BUG: rank is always unranked - Githubissues

billy-yoyo / RainbowSixSiege-Python-API

Asynchronous python api for rainbow six siege (r6sapi)

MIT License

130 stars 31 forks source link

BUG: rank is always unranked #75

Open Jackywathy opened 3 years ago

Jackywathy commented 3 years ago

the get_rank based on rank_id is incomplete. It currently returns UNRANKED. We should try to fix this up before release. Unfortunately missed this before sending the earlier pull request.

need to somehow differentiate between old style vs new style ranks (since ubi changed the rank system). This is currently done by hard coding each season's ranks in season.py (possible enhancement in the future could be to consolidate this into just two).

[x] implement get_rank(rank_id) to return the rank corresponding to that rank id
[x] add rank definitions for earlier seasons
[ ] ensure rank works for each season (commit this as a example file so we can test this in the future)

Jackywathy commented 3 years ago

@billy-yoyo probably best not to release till this is fixed - should be pretty simple though.