Closed cdmckinley closed 2 years ago
@cdmckinley Thanks for the feedback.
It's good to hear from two people not as well versed in the cyber-security world. I suppose it might be good to explain some of the concepts better. I should mention that the primary users of this are going to be in either security or security-adjacent technology-services roles (e.g. Server Admin, Desktop Engineering, etc).
Regarding the mobile device question... I think this is going to be designed for desktop only at this point. It would just have too much detailed information to display well on a mobile phone, although that could be a good iteration 2 idea. One of the other ideas proposed by my cyber security supervisors was a native mobile app for Splunk, but that didn't seem to fit the nature of the project requirements. Being a browser-based client-side UI, I suppose I could try to incorporate mobile design into it as well, but I see that as being a somewhat lower priority at this point
Design/Code Review 1
Project:
NessusTools
Developer:
Bill Anderson
Reviewer:
2. Is professional and free of typos, slang, etc.
3. Fully explains the problem and the solution
4. Is understandable by the average person
2. The order in which values are displayed are logical and easy to understand/use
3. The order in which the form fields entered are logical and easy to understand/use
4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens
2. There is at least one 1-to-many relationship.
3. The model represents good database design
2. a .gitignore file for IntelliJ Java projects has been implemented
3. There is not any redundant or copy/paste code in the JSPs or classes
4. Classes are appropriately-sized (no monster classes)
Property files are used appropriately: no hard-coded values
5. Logging statements are used rather than System.out.println and printStackTrace.
6. There are appropriate unit tests/code coverage.