billyhoce / pe

0 stars 0 forks source link

UG: Pin command behaviour is not specified #18

Open billyhoce opened 6 months ago

billyhoce commented 6 months ago

The UG shows the proper format and even examples of how to use the Pin command which is good! However, it fails to show the behaviour. From my testing, I found out that pinning a person moves them to the top of the list forever, even after closing the app, or using the "find" followed by "view" command. Also, I found out that pinning a second person moves the originally-pinned person to the second position on the list forever. You can even pin somebody multiple times, each time just bringing them up to the top. This behaviour needs to be specified in the UG for better clarity!

nus-se-script commented 6 months ago

Team's Response

It is exactly the behaviour of the pin command and it is rather intuitive. When a user is pinned, the user will be brought up to the top of the contact list. And it is fair to provide user with the ability to be able to pin the person multiple times. For instance, if a user pins person 1,2,3 in that order (1,2,3) so the order of the person will now appear as person 3 --> person 2 --> person 1 when viewing our contact list. Now then when the user realises that person 1 has teh utmost importance, he should be able to use the pin command again to pin that person, sending that person back to the top, which is our intended behaviour. Therefore, we feel that this command is as what our UG mentions: "Pins a person to the top of AronaPro."

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Yes, I do not disagree with the behaviour of pin! What I am saying is that the behaviour of pinning multiple (and possibly repeated pinning of the same individual) is not clearly specified in the UG.

Some users might be thinking "how do I unpin" or "why when I pin two people, the first person is not on top anymore".

You might think that the behaviour is intuitive, but it might not be for others. For example, telegram's pinning behaviour is different from yours. The first pinned person will always be at the top