search

billyhoce / pe

0 stars 0 forks source link

Overzealous input validation for NUSID #5

Open billyhoce opened 6 months ago

billyhoce commented 6 months ago

I agree that most student NUSNET IDs are in the format EXXXXXXX, however, do staff's ID (professors) have the same format? What if NUS decides to change the format for students as well?

nus-pe-bot commented 6 months ago

Team's Response

After brief research into NUS staff, it is possible that the format of their ID is not in the form of EXXXXXXX (unable to confirm with web serach). This would render the app unusable because of unique identification and over-zealous input, however our team feels that the app can evolve in the future iterations based on when NUS does change formats for NUSIDs.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: You said that

After brief research into NUS staff, it is possible that the format of their ID is not in the form of EXXXXXXX

If that was the case, that would result in some features of your app not usable at all (such as adding professors), or users would have to circumvent around by entering dummy NUSNET-ID because your app currently makes it compulsory for everyone to have an NUSNET-ID. This definitely causes inconvenience to users, and since every module has a professor, it would not a far stretch to say that every user will be affected by this. It is definitely in scope as its one of the core functionality of your application.