Ensure QR Code is URI Encoded to handle spaces in organization name

billylo1 / covidpass

Web app for adding Ontario vaccination records to Apple Wallet (forked from covidpass in EU)

https://grassroots.vaccine-ontario.ca

MIT License

79 stars 12 forks source link

Ensure QR Code is URI Encoded to handle spaces in organization name #10

Closed mutantlog closed 2 years ago

mutantlog commented 2 years ago

Re: issue #9

Adds encodeURIComponent() function to each of the payload data when constructing the QR code, to ensure that URL is correctly generated when spaces are present in any of the values. Verified with Google Lens and Barcode Scanner+

mutantlog commented 2 years ago

It looks like similar functionality has been added to src/pass.ts, but there isn't a corresponding change in src/photo.ts.

mutantlog commented 2 years ago

I don't know if I did this optimally in terms of git processes, but this pull request now only contains the changes made by @billylo1 in pass.ts copied into photo.ts as well.

mutantlog commented 2 years ago

Already implemented in commit b38540a