Closed Coteh closed 2 years ago
@Coteh thank you very much for doing this! Definitely please let us know if you find a fix for the file-saver module issue - we probably need to make sure the whole flow works before we can merge iPhone 6 support, however I know we've gotten numerous requests for it so that will be very appreciated if we can get it working!
@straxus I was able to narrow it down to html-to-image
library erroring out when parsing
characters. I replaced it with a margin-left and the image was then able to be saved fine using file-saver
.
Also, I noticed that if image/png
is in the accept
attribute for file input, then my iPhone 6 won't let me select a PDF. I changed it to .png
instead after reading this SO post and it seemed to fix the problem. I also checked the iPhone 11 simulator I was using, which did not experience this, and it still accepts both PDFs and PNGs even after this change.
@Coteh excellent, thank you very much for your work on this and for your help in improving our older iOS version support!
I do not have an Apple Developer account currently, so I cannot test Apple Wallet pkpass generation and backend verification. However, I can verify that the Save Photo feature continues to print the receipt as expected on both my iPhone (iPhone 6 12.5.4) and my Mac (Safari 14.1.1 (15611.2.7.1.6, 15611), Firefox 92.0.1 (64-bit), and Chrome 94.0.4606.61 (Official Build) (x86_64)).
edit: Did another test and noticed that on my iPhone 6, the photo is generated but does not save. I believe this is due to
file-saver
module - it should open a new window with the image upon call tosaveAs
, not sure how to solve this yet.