billylo1 / covidpass

Web app for adding Ontario vaccination records to Apple Wallet (forked from covidpass in EU)
https://grassroots.vaccine-ontario.ca
MIT License
79 stars 12 forks source link

Add Alberta's public key #36

Closed grepme closed 2 years ago

grepme commented 2 years ago

After much searching, I have finally stumbled upon Alberta's public key. I confirmed it against my personal QR Code.

corrmaan commented 2 years ago

@grepme and @straxus Wondering if you could please elaborate on how you find the public keys. I'm looking to do the same for Nova Scotia.

straxus commented 2 years ago

@grepme and @straxus Wondering if you could please elaborate on how you find the public keys. I'm looking to do the same for Nova Scotia.

Has Nova Scotia released an SHC QR code yet? If so, then you will want to decode it and look for a code block that looks like this: https://github.com/billylo1/covidpass/blob/shc-refactoring/examples/shc-ca-bc-decoded.json#L2

for this Issuer (https://smarthealthcard.phsa.ca/v1/issuer), the public key is at https://smarthealthcard.phsa.ca/v1/issuer/.well-known/jwks.json as this is required by the SHC standard (issuer URL + /.well-known/jwks.json)

corrmaan commented 2 years ago

Yes they released it on October 4, 2021.

Many thanks for the info, I'll dig into it in the next few days. I've decoded my SHC QR already and have the issuer link, so your helpful key link might be all that's required for me to make a PR.

I imagine that other code edits will be necessary, and that hopefully I'll discover them with some testing.

straxus commented 2 years ago

Yes they released it on October 4, 2021.

Many thanks for the info, I'll dig into it in the next few days. I've decoded my SHC QR already and have the issuer link, so your helpful key link might be all that's required for me to make a PR.

I imagine that other code edits will be necessary, and that hopefully I'll discover them with some testing.

Fantastic, thank you very much!! And it would be extremely helpful as part of that PR if you could add an example (with all info redacted) to the examples/ folder I pointed at in the previous comment as it helps to understand similarities and differences between the QR codes for different provinces. If you can put that example and the public key into a PR against shc-refactor, I can take it from there on the current shc-refactor branch (that's approaching completion already, and has more generalized multi-jurisdiction support compared to current main branch).

Thanks!

corrmaan commented 2 years ago

Oops, I made https://github.com/billylo1/covidpass/pull/37 before I read your comment! I'll work on making an example for NS in the next few days. They're also releasing their app on Oct 22 so there's a bit of time yet.