billylo1 / covidpass

Web app for adding Ontario vaccination records to Apple Wallet (forked from covidpass in EU)
https://grassroots.vaccine-ontario.ca
MIT License
79 stars 12 forks source link

The passbook button works on Firefox and Edge (Windows 10) but is disabled #7

Closed hdpinto closed 2 years ago

hdpinto commented 2 years ago

After removing disabled=true from the submit button using dev tools, the pkpass file was still created and I was able to load it onto my phone successfully.

I would recommend not arbitrarily restricting browsers since these passes work on several apps for android as well, and not everyone uses or wants to use chrome. I was able to find this workaround and still get my pass on my android phone (no chrome installed), but if possible I would suggest the button not be disabled unless there is a functional reason not to enable it.

straxus commented 2 years ago

We've loosened up the rules around this to give people more chances to save this - I believe this resolves the issue noted above.