billymwlei / googletransitdatafeed

Automatically exported from code.google.com/p/googletransitdatafeed
0 stars 0 forks source link

Allow unknown files with all unknown columns without throwing an error. #323

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently, if there is an unknown file in a feed that parses as CSV, we throw 
an error because the file has no known columns.  However, I think this error is 
a bit beyond the original intention of the validation check, which was to look 
for a known GTFS file that didn't specify any known columns.  I propose to 
relax this check to allow unknown files (whose existence already causes a 
warning) to not throw an error for having unknown columns.

Such a feature allows an agency or developer to include additional CSV files in 
their feed that potentially support new alternative functionality.  We don't 
want the validator to fail in those cases.

Original issue reported on code.google.com by bdfer...@google.com on 27 Feb 2012 at 4:54

GoogleCodeExporter commented 9 years ago

Original comment by bdfer...@google.com on 27 Feb 2012 at 4:54

GoogleCodeExporter commented 9 years ago
Just a comment - is it actually an error currently? I have included two unknown 
CSV files in the feed for a few years now and I have only ever received a 
warning from the validator.

Original comment by db.sd...@gmail.com on 27 Feb 2012 at 5:24

Attachments:

GoogleCodeExporter commented 9 years ago
Looking into this issue a bit more clearly, I discovered that I had an internal 
extension to the feedvalidator that was adding a mapping for my new file but 
with no columns.  Since this was a problem on my end, I'm closing the bug.

Original comment by bdfer...@google.com on 28 Feb 2012 at 11:28

GoogleCodeExporter commented 9 years ago

Original comment by bdfer...@google.com on 28 Feb 2012 at 11:28

GoogleCodeExporter commented 9 years ago

Original comment by bdfer...@google.com on 26 Sep 2014 at 4:32