search

billymwlei / googletransitdatafeed

Automatically exported from code.google.com/p/googletransitdatafeed
0 stars 0 forks source link

Transxchange2GoogleTransit doesn't follow best practise in use of types and doesn't use generics #335

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Transxchange2GoogleTransit uses HashMap and ArrayList in method signatures and 
field variables rather than using Map and List as is best practice.
It doesn't use generics at all which results in casts all over the place and 
reduces type safety (I found one type safety bug in a dumpValues method).

I have a patch which addresses this problem by fixing all the cases.

Original issue reported on code.google.com by scottish...@googlemail.com on 8 Jun 2012 at 10:08

Attachments: