Errors and warnings when building with Visual Studio 2015

billyquith / ponder

C++ reflection library with Lua binding, and JSON and XML serialisation.

http://billyquith.github.io/ponder/

Other

640 stars 93 forks source link

Closed AntAgna closed 7 years ago

AntAgna commented 7 years ago

I experienced a few errors and warnings when compiling master with Visual Studio 2015.

Name collision with free and new macros when using memory leak detection
Two minor warnings in format.cpp
Type conversion warning (int to wchar_t) in format.cpp
bad_conversion class uses non public inheritance of std::exception caused warnings C4673 and C4670

The last one is a significant bug since it means exceptions would not have been caught by catch (const std::exception& e).

billyquith commented 7 years ago

Name collision with free and new macros when using memory leak detection

Hopefully you didn't find any leaks. I haven't tested for them myself.

billyquith commented 7 years ago

Type conversion warning (int to wchar_t) in format.cpp

Thanks for your work here but I think I may just remove fmt and use iostream. See #59. Just one less dependency.

AntAgna commented 7 years ago

I have seen no leaks