search

billyrieger / bimap-rs

Generic bijective maps in Rust
Apache License 2.0
129 stars 26 forks source link

Align BiBTreeMap Debug with BiHashMap Debug #38

Closed rob9315 closed 1 year ago

rob9315 commented 1 year ago

BiBTreeMap did not apply the formatting arguments to the items like BiHashMap does. Maybe it should be considered to move the EntryDebugger struct out of the impl so that BiBTreeMap and BiHashMap can share it. If that is desired, please suggest where to move it to.

billyrieger commented 1 year ago

Looks good, thank you! For now I think it's fine to duplicate the debugging code between the two BiMaps, eventually I'd like to develop a better way to share code between them.