billyvg / OverlayPlugin-themes

Different layouts for FFXIV ACT OverlayPlugin
74 stars 28 forks source link

Fixed Header to use Group Data and not self data #15

Closed christianallred closed 7 years ago

christianallred commented 7 years ago

This fix is not ideal as i am iterating through the list of combantants for this data so performance will suffer a bit. But it actually real data instead of using self data only. Once the Encounter object is udpated with the new data types we can revert this and use the Encounter object in the header.

christianallred commented 7 years ago

I pulled the most recent changes made and noticed some changes where made to the headers data sources.

It would be better to instead add a toggle once the header is open to either view "my data" or view the "groups" data. this way the data is not contaminated by cross using the data sets.

Gonna work on getting the toggle set up later today

christianallred commented 7 years ago

Also i removed crit heal % as that data is not currently being parse properly by the FFXIV plugin.